Skip to content

Format with Prettier#115

Open
mwojick-keeper wants to merge 4 commits intomainfrom
prettier
Open

Format with Prettier#115
mwojick-keeper wants to merge 4 commits intomainfrom
prettier

Conversation

@mwojick-keeper
Copy link
Contributor

@mwojick-keeper mwojick-keeper commented Mar 5, 2026

These are the only real changes:
49df92e
3e58c4e

The rest is formatting from npm run format

The format commit (and others added to .git-blame-ignore-revs) can be ignored in the blame by running:
git config blame.ignoreRevsFile .git-blame-ignore-revs

@mwojick-keeper mwojick-keeper changed the title Prettier Format with Prettier Mar 5, 2026
Copy link
Contributor

@tylerccarson tylerccarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few general thoughts here:

  • prettier hasn't been added as a dev dependency, and no script has been added to format the project. If we're going to add a formatter, we should be giving devs a way to use it, and we should be enforcing it in CI.
  • keeperapi is where we write the code for the actual package, I'd say focus on putting the .rc file, dep, and script there and don't worry about the examples directory since that's largely unmaintained
  • I tried running blame locally, and that revs file doesn't get used automatically, which is unfortunate. If there's a way to do that so that we don't have to pass a flag / option, it would be more ideal

@mwojick-keeper
Copy link
Contributor Author

A few general thoughts here:

  • prettier hasn't been added as a dev dependency, and no script has been added to format the project. If we're going to add a formatter, we should be giving devs a way to use it, and we should be enforcing it in CI.
  • keeperapi is where we write the code for the actual package, I'd say focus on putting the .rc file, dep, and script there and don't worry about the examples directory since that's largely unmaintained
  • I tried running blame locally, and that revs file doesn't get used automatically, which is unfortunate. If there's a way to do that so that we don't have to pass a flag / option, it would be more ideal

Good points, will try to address all those. For the rev file, would it be ok to put the git config cmd in a postinstall script? or just add it to the readme?

@tylerccarson
Copy link
Contributor

Good points, will try to address all those. For the rev file, would it be ok to put the git config cmd in a postinstall script? or just add it to the readme?

Readme probably best bet, sounds like it should be more of an opt-in thing but good to have a quick reference on how to do so

@socket-security
Copy link

socket-security bot commented Mar 12, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedprettier@​3.8.1901009793100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants