Open
Conversation
Contributor
tylerccarson
left a comment
There was a problem hiding this comment.
A few general thoughts here:
- prettier hasn't been added as a dev dependency, and no script has been added to format the project. If we're going to add a formatter, we should be giving devs a way to use it, and we should be enforcing it in CI.
keeperapiis where we write the code for the actual package, I'd say focus on putting the .rc file, dep, and script there and don't worry about theexamplesdirectory since that's largely unmaintained- I tried running blame locally, and that revs file doesn't get used automatically, which is unfortunate. If there's a way to do that so that we don't have to pass a flag / option, it would be more ideal
Contributor
Author
Good points, will try to address all those. For the rev file, would it be ok to put the git config cmd in a postinstall script? or just add it to the readme? |
Contributor
Readme probably best bet, sounds like it should be more of an opt-in thing but good to have a quick reference on how to do so |
2df3f2c to
7ac28be
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
7ac28be to
3e58c4e
Compare
saldoukhov
approved these changes
Mar 17, 2026
saldoukhov
approved these changes
Mar 17, 2026
tylerccarson
approved these changes
Mar 17, 2026
THeflinKeeper
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the only real changes:
49df92e
3e58c4e
The rest is formatting from
npm run formatThe format commit (and others added to .git-blame-ignore-revs) can be ignored in the blame by running:
git config blame.ignoreRevsFile .git-blame-ignore-revs