Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Adds the RedDino (large) model as a new feature extractor option in STAMP’s preprocessing pipeline, wiring it into configuration/dispatch and documenting it for users.
Changes:
- Introduces a new
red_dinoextractor implementation (RedDino-large) and class-token-only wrapper. - Registers
ExtractorName.RED_DINOand adds extractor dispatch inpreprocessing.extract_. - Updates docs to list RedDino as a supported feature extractor; also includes minor UNI2 typing/import adjustments.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/stamp/preprocessing/extractor/uni2.py |
Updates UNI2 imports/types and transform typing. |
src/stamp/preprocessing/extractor/reddino.py |
Implements the RedDino-large extractor and output wrapper. |
src/stamp/preprocessing/config.py |
Adds RED_DINO to ExtractorName. |
src/stamp/preprocessing/__init__.py |
Routes ExtractorName.RED_DINO to the new extractor factory. |
getting-started.md |
Documents RedDino as a supported extractor and adds a link reference. |
Comments suppressed due to low confidence (1)
src/stamp/preprocessing/extractor/uni2.py:14
- This error message points users to install
stamp[uni2], but there is nouni2optional-dependency extra defined in pyproject.toml. Consider updating the message to reference an existing extra (e.g.cpu/gpu) or remove the extra-specific guidance so installation instructions remain accurate.
raise ModuleNotFoundError(
"uni2 dependencies not installed."
" Please reinstall stamp using `pip install 'stamp[uni2]'`"
) from e
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
4 tasks
Contributor
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
JonasRichartz
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding Red Dino (large) as feature extractor