Open
Conversation
NailShaykhrazievItis
approved these changes
Jan 6, 2022
| AppDatabase::class.java, | ||
| "app-db" | ||
| ).run { | ||
| allowMainThreadQueries() |
There was a problem hiding this comment.
Для корутин можно было уже убрать
| database = Room.databaseBuilder( | ||
| applicationContext, | ||
| AppDatabase::class.java, | ||
| "app-db" |
There was a problem hiding this comment.
лучше добавить расширение .db, и вынести в константу
| override fun onCreate() { | ||
| super.onCreate() | ||
| instance = this | ||
| database = Room.databaseBuilder( |
There was a problem hiding this comment.
лучше код создание бд оставить внутри класса AppDatabase, чтобы потом можно было в другом месте переиспользовать при необходисомти
| override fun submitList(list: MutableList<Task>?) { | ||
| super.submitList( | ||
| if (list == null) null | ||
| else ArrayList(list) |
There was a problem hiding this comment.
перенос строки тут не нужен
|
|
||
| private suspend fun setTaskEditingView(id: Int) { | ||
| val task = scope.async { | ||
| withContext(Dispatchers.IO) { |
There was a problem hiding this comment.
в данном случае ты мог написать scope.async(Dispatchers.IO) {}
но а так для рума и в этом нужды нет, под коробкой он генерит код с withContext(IO)
| database?.taskDao()?.findById(id) | ||
| } | ||
| }.await() | ||
| binding?.apply { |
There was a problem hiding this comment.
cемантически здесь будет верно run
| calendar?.also { | ||
| task.date = it.time | ||
| } | ||
| scope.launch { |
There was a problem hiding this comment.
Аналогично, мог сразу launch(io) написать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.