Skip to content

Remove compat entries for differentiation libraries#33

Closed
jackyarndley wants to merge 3 commits intoJuliaSpace:masterfrom
jackyarndley:master
Closed

Remove compat entries for differentiation libraries#33
jackyarndley wants to merge 3 commits intoJuliaSpace:masterfrom
jackyarndley:master

Conversation

@jackyarndley
Copy link
Copy Markdown

This PR removes the compat entries for differentiation libraries which prevented some of them from updating to newer versions. I have left the compat entry for DifferentiationInterface.

The tests are also modified to remove the requirements for Mooncake which was not used and currently has issues updating to Julia 1.12 which I am currently using. All tests now pass on this version.

It may be important to add some kind of extension compat for the Zygote extension since this uses the Zygote internal methods.

@ronisbr
Copy link
Copy Markdown
Member

ronisbr commented Jun 27, 2025

Hi @jackyarndley !

If we remove those compat, we will have problems registering the packages. Notice that Zygote and FowardDiff are weakdeps using in the extensions.

@ronisbr
Copy link
Copy Markdown
Member

ronisbr commented Jun 27, 2025

Oh sorry @jackyarndley !

I have already commit a patch that should fix this issue. It is almost the same as you proposed here, but FiniteDiff stayed with the lower version as 2.26

@ronisbr
Copy link
Copy Markdown
Member

ronisbr commented Jun 27, 2025

Can you please check if the version in master is working?

@jackyarndley
Copy link
Copy Markdown
Author

@ronisbr, thank you for being so prompt! The version in master works great - my own project can now use the latest version. I will close this PR.

If you have a chance, could you please investigate not having the Mooncake dependency for the tests - it doesn't seem to be used and prevents testing this package on the (soon to be) latest Julia version.

@ronisbr
Copy link
Copy Markdown
Member

ronisbr commented Jun 27, 2025

@ronisbr, thank you for being so prompt! The version in master works great - my own project can now use the latest version. I will close this PR.

Awesome! I am glad to help :) I have just ask for registration of 3.1.1 which you fix this problem.

If you have a chance, could you please investigate not having the Mooncake dependency for the tests - it doesn't seem to be used and prevents testing this package on the (soon to be) latest Julia version.

I have already mentioned it to @jmurphy6895. I think he will investigate it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants