Fix tracking URI to explicitly append /api to map to REST route#78
Open
aryawadhwa wants to merge 1 commit intoJuliaAI:mainfrom
Open
Fix tracking URI to explicitly append /api to map to REST route#78aryawadhwa wants to merge 1 commit intoJuliaAI:mainfrom
aryawadhwa wants to merge 1 commit intoJuliaAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1075
Description
When users provide an
MLFLOW_TRACKING_URIassociated with remote services like DagsHub (e.g.,https://dagshub.com/username/repo.mlflow), the underlying HTTP requests currently fail due to 404 HTML redirects.This occurs because standard MLflow REST API calls expect the
/apiroute, but MLFlowClient.jl currently enforces the raw URI provided inENV["MLFLOW_TRACKING_URI"]without validating or appending the required/apisuffix.Changes Made
MLFlowconstructor in src/types/mlflow.jl to gracefully append/apiif missing when parsing tracking URIs from the environment.@testsetin test/types/mlflow.jl rigorously unit testing the tracking URI manipulation against multiple edge cases (missing slash, trailing slash, already contains/api, etc.).Testing
Ran
Pkg.test()locally and all tests gracefully pass while successfully shielding the downstreamruntests.jlenvironment state.