This repository was archived by the owner on Apr 9, 2025. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have made the following updates:
Two new CLI flags
-x hides the banner, author name, version, usage etc.
-f saves any found emails to a file specified by the user.
Removed explicit thread count. By not specifying ThreadPoolExecutor will make the count (current processors*5)
Updated banner info code to make use of a multi-line f-string.
Updated requirements.txt to use the latest versions.
Style changes:
Updated many stdout messages to have capital first letter
No longer prints done; if finds emails display message else display " did not find" message
Updated message if no emails found.
This is my first ever PR, I have only been learning Python 3 for the last 2 weeks.
Please let me know if these changes are not suitable or need further amendment.