Skip to content

Reduce bank access and MC checks in DC hit reading #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
baltzell wants to merge 8 commits into
base: development
Choose a base branch
from
Draft

Reduce bank access and MC checks in DC hit reading #1179

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
211f4de
use bank index instead of string
baltzell Apr 2, 2026
c61c818
reduce check calculations and redundancies
baltzell Apr 3, 2026
7d87bf0
remove redundant bank access, cleanup logic
baltzell Apr 3, 2026
b62ffd5
Revert "use bank index instead of string"
baltzell Apr 3, 2026
a6abc50
stop rereading start time from bank
baltzell Apr 3, 2026
efc2d8d
make em final
baltzell Apr 3, 2026
1f9123a
reduce bank accesses
baltzell Apr 3, 2026
2632dfe
reduce bank accesses
baltzell Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 16 additions & 24 deletions reconstruction/dc/src/main/java/org/jlab/rec/dc/banks/HitReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,11 @@ private void read_HBHits(TimeToDistanceEstimator tde) {

DataBank pbank = event.getBank(pointName);
for (int i = 0; i < pbank.rows(); i++) {
id2tid.put((int)pbank.getShort("id", i), (int)pbank.getShort("tid", i));
id2tidB.put((int)pbank.getShort("id", i), (double)pbank.getFloat("B", i));
id2tidtFlight.put((int)pbank.getShort("id", i), (double)pbank.getFloat("TFlight", i));
id2tidtProp.put((int)pbank.getShort("id", i), (double)pbank.getFloat("TProp", i));
int id = pbank.getShort("id",i);
id2tid.put(id, (int)pbank.getShort("tid", i));
id2tidB.put(id, (double)pbank.getFloat("B", i));
id2tidtFlight.put(id, (double)pbank.getFloat("TFlight", i));
id2tidtProp.put(id, (double)pbank.getFloat("TProp", i));
}

DataBank bank = event.getBank(bankName);
Expand All @@ -356,6 +357,10 @@ private void read_HBHits(TimeToDistanceEstimator tde) {
double[] tFlight = new double[rows];
double[] trkDoca = new double[rows];

final boolean ismc = event.hasBank("MC::Particle") ? true : event.getBank("RUN::config").getInt("run",0)<=100;

final double T_Start = ismc || !event.hasBank(recBankName) ? 0 : event.getBank(recBankName).getFloat("startTime", 0);

for (int i = 0; i < rows; i++) {
id[i] = bank.getShort("id", i);
status[i] = bank.getShort("status", i);
Expand All @@ -378,8 +383,7 @@ private void read_HBHits(TimeToDistanceEstimator tde) {
tFlight[i] = this.id2tidtFlight.get(id[i]);
}

if (event.hasBank("MC::Particle") ||
event.getBank("RUN::config").getInt("run", 0) < 100) {
if (ismc) {
tProp[i] = 0;
tFlight[i] = 0;
}
Expand All @@ -393,25 +397,15 @@ private void read_HBHits(TimeToDistanceEstimator tde) {
continue;
}

double T_0 = 0;
double T_Start = 0;

if (!event.hasBank(recBankName)) {
continue;
}

if (event.hasBank(recBankName) &&
event.getBank(recBankName).getFloat("startTime", 0)==-1000) {
double T_0 = 0;
if (T_Start == -1000) {
continue;
}

if (!event.hasBank("MC::Particle") &&
event.getBank("RUN::config").getInt("run", 0) > 100) {
//T_0 = this.getT0(sector[i], slayer[i], layer[i], wire[i], T0, T0ERR)[0];
if (event.hasBank(recBankName))
T_Start = event.getBank(recBankName).getFloat("startTime", 0);
}

T_0 = this.getT0(sector[i], slayer[i], layer[i], wire[i], t0s)[0];
FittedHit hit = new FittedHit(sector[i], slayer[i], layer[i], wire[i], tdc[i], jitter[i], id[i]);
hit.set_Id(id[i]);
Expand Down Expand Up @@ -621,12 +615,10 @@ private void setToPionHypothesis(DataEvent event, int trkId, FittedHit hit) {
for (int i = 0; i < rows; i++) {
if (bank.getByte("detector", i) == 6 &&
bank.getShort("index", i) == trkId - 1) {
px = event.getBank(partBankName).getFloat("px",
bank.getShort("pindex", i));
py = event.getBank(partBankName).getFloat("py",
bank.getShort("pindex", i));
pz = event.getBank(partBankName).getFloat("pz",
bank.getShort("pindex", i));
short pindex = bank.getShort("pindex",i);
px = event.getBank(partBankName).getFloat("px",pindex);
py = event.getBank(partBankName).getFloat("py",pindex);
pz = event.getBank(partBankName).getFloat("pz",pindex);
}
}

Expand Down
Loading