correct the calculation of z positions of clusters and docaclusters#1165
Open
zyzhangjlab wants to merge 1 commit intoJeffersonLab:developmentfrom
Open
correct the calculation of z positions of clusters and docaclusters#1165zyzhangjlab wants to merge 1 commit intoJeffersonLab:developmentfrom
zyzhangjlab wants to merge 1 commit intoJeffersonLab:developmentfrom
Conversation
Collaborator
|
I think @hauenst mentioned this is related to geometry consistency between simulation and reconstruction? |
whit2333
requested changes
Mar 30, 2026
| Hit h = pc.get_hits_list().get(0); | ||
| return h.getLine(); | ||
| } | ||
| public static double getStereoAngleDeg(int superlayerId) { |
Collaborator
There was a problem hiding this comment.
Why is this here? This is not using "single source of geometry" information.
Contributor
Author
There was a problem hiding this comment.
I mean to get the origin and end z position from geometry with one line from one precluster.
Collaborator
There was a problem hiding this comment.
@zyzhangjlab I think it is about the stereo angles. Can you find a way to retrieve them using only the geometry? We don't want hard coded values.
Contributor
Author
There was a problem hiding this comment.
@ftouchte I see I can calculate them using only the geometry. I will do this later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.