Fix AP/mAP degradation due to unsorted prediction confidence scores & Add IoU Zero-Division Safeguard#545
Open
shardulmahamulkar wants to merge 1 commit intoJdeRobot:masterfrom
Conversation
…andle IoU zero division
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two critical bugs in the perceptionmetrics detection evaluation pipeline that result in artificially degraded AP (Average Precision) scores and potential crashes:
Prediction Confidence Sorting (#Bug 3): Standard evaluation mapping protocols dictate that multiple boxes targeting a single ground truth must be resolved sequentially in descending order of their confidence scores. The _match_predictions() method was evaluating mapping criteria based on arbitrary array index order. This allowed low-scoring detections to lock in early as the True Positive target, delegating higher confidence detections as False Positives, unjustly penalizing high-threshold precision curves.
Degenerate Area Bug / IoU Zero-Division Safeguard (#Bug 1): compute_iou() did not protect against zero-area unions (i.e., evaluating degenerate predicted or ground-truth boxes), causing ZeroDivisionError crashes mid-evaluation. A safeguard was implemented to return 0.0 seamlessly in these cases without halting execution.
Changes Made
How to Verify
Related Issues
Closes #544