Skip to content

Use tempdir-spec on macos#170

Merged
Eeems merged 4 commits intomainfrom
tmpdir-spec
Mar 14, 2026
Merged

Use tempdir-spec on macos#170
Eeems merged 4 commits intomainfrom
tmpdir-spec

Conversation

@Eeems
Copy link
Collaborator

@Eeems Eeems commented Mar 13, 2026

Summary by CodeRabbit

  • Chores
    • macOS packaging adjusted to use a dedicated temporary directory during one-file builds for more reliable deployment.
    • Build now embeds product and file version metadata based on the build date and time, providing clearer versioning for produced executables.

@Eeems Eeems linked an issue Mar 13, 2026 that may be closed by this pull request
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5cbb8b4c-66d2-48e5-a230-bde0a678ea89

📥 Commits

Reviewing files that changed from the base of the PR and between 543185b and 09027fd.

📒 Files selected for processing (2)
  • Makefile
  • main.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • main.py

Walkthrough

Adds conditional macOS (Darwin) Nuitka build directives in main.py and appends date/time-based --product-version and --file-version flags to the Nuitka invocation in the Makefile; changes affect build metadata and macOS onefile tempdir spec only.

Changes

Cohort / File(s) Summary
Nuitka Build Configuration
main.py
Added conditional nuitka-project-if: {OS} == "Darwin": block with nuitka-project: --onefile-tempdir-spec="{CACHE_DIR}/codexctl/{VERSION}" to apply onefile tempdir spec on macOS.
Makefile — Build Flags
Makefile
Added --product-version=$(shell date +%Y.%m.%d) and --file-version=$(shell date +%H.%M.%S) to the Nuitka command in the executable target to embed build date/time as version metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Fix build #139 — Also modifies Nuitka build configuration (Makefile and nuitka-project directives), likely related to build metadata/tempdir handling.
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Use tempdir-spec on macos' accurately describes the primary change in main.py, but the changeset also includes significant versioning changes in the Makefile that are not reflected in the title. Revise the title to reflect both main changes, such as 'Add macOS tempdir-spec and embed compile datetime as version' or split into two focused PRs.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tmpdir-spec
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]

This comment was marked as resolved.

@Eeems

This comment was marked as resolved.

@coderabbitai

This comment was marked as resolved.

@Eeems Eeems merged commit da4ad22 into main Mar 14, 2026
14 checks passed
@Eeems Eeems deleted the tmpdir-spec branch March 14, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cold start time slow on macOS

1 participant