Modified readme to talk about Websockets reborn specifically#69
Closed
relyt29 wants to merge 284 commits intoJavaJens:feature/websocket-rebornfrom
relyt29:feature/websocket-reborn
Closed
Modified readme to talk about Websockets reborn specifically#69relyt29 wants to merge 284 commits intoJavaJens:feature/websocket-rebornfrom relyt29:feature/websocket-reborn
relyt29 wants to merge 284 commits intoJavaJens:feature/websocket-rebornfrom
relyt29:feature/websocket-reborn
Conversation
README.md
Outdated
Owner
There was a problem hiding this comment.
Maybe we should change this also?
There was a problem hiding this comment.
I suggest:
## Contributing Bug reports related to WebSocket support We use GitHub for bug tracking. Please search the existing issues for your bug and create a new one if the issue is not yet tracked! https://github.com/JavaJens/TextSecure/issues ## Contributing Bug reports upstream for the base application They also use GitHub for bug tracking. Please search the existing issues for your bug and create a new one if the issue is not yet tracked! https://github.com/WhisperSystems/Signal-Android/issues
|
Since per my understanding this fork is just for one feature, I would not merge this PR. When merging new upstream changes I always closely check the new diff against upstream and this README change would be very annoying. If you want to have a more accurate readme, please let @xmikos create his own fork for support related questions for LibreSignal and change the readme there as I have argued in #72. |
Closes signalapp#5325 // FREEBIE
// FREEBIE
// FREEBIE
Fixes signalapp#5337 // FREEBIE
// FREEBIE
Fixes signalapp#5342 Closes signalapp#5343 // FREEBIE
// FREEBIE
Closes signalapp#5352 // FREEBIE
Closes signalapp#5228 // FREEBIE
Just in case someone tries something sneaky... // FREEBIE
// FREEBIE
// FREEBIE
Fixes signalapp#5958 // FREEBIE
Fixes signalapp#5928 // FREEBIE
Fixes signalapp#5930 // FREEBIE
Fixes signalapp#5908 Closes signalapp#5917 // FREEBIE
Closes signalapp#5916 // FREEBIE
// FREEBIE
Fixes signalapp#5955 // FREEBIE
// FREEBIE
// FREEBIE
// FREEBIE
// FREEBIE
// FREEBIE
// FREEBIE
Fixes signalapp#5980 // FREEBIE
// FREEBIE
// FREEBIE
Author
|
this has long since become irrelevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If anyone else has something they think should be added please comment.