Open
Conversation
✅ Deploy Preview for blockbench-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
SnaveSutit
force-pushed
the
feature/improved-generate-types
branch
from
19f4c1a to
8d6469e
Compare
- Renamed `convert_types.js` -> `generate_types.js`. - Converted `generate_types.js` to TypeScript. - Added `--watch` argument to `generate-types`. - Added support for Regex to the `excluded` list in `type_config.json`.
A list of files to keep, but not transform.
SnaveSutit
force-pushed
the
feature/improved-generate-types
branch
from
8d6469e to
baa2e57
Compare
codeCraft-Ritik
left a comment
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Great contribution! The implementation is clean and integrates well with the existing codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got a little annoyed with having to manually re-run the
generate-typesscript every time I made a change.So here's an improved version!
Changes
convert_types.js->generate_types.js.generate_types.jsto TypeScript.--watchargument togenerate-types.type_config.jsonexcludedlist not actually being excluded../types/README.mdfor--watchargument.