Open
Conversation
JakeWharton
reviewed
Mar 27, 2026
| val newCount = newVersionMap.values.count { it == version } | ||
| BytecodeVersionDiff.Count(oldCount) to BytecodeVersionDiff.Count(newCount) | ||
| } | ||
| .filter { (_, counts) -> counts.first != counts.second } |
Owner
There was a problem hiding this comment.
I'm not too sure about this behavior. I'm tempted to say that if we show the diff at all, we want to show all counts just for the clarity of it.
JakeWharton
reviewed
Mar 27, 2026
Comment on lines
+256
to
+257
| // Classes shifted versions but net counts per version stayed same. | ||
| // Table is hidden, but class list is shown. |
Owner
There was a problem hiding this comment.
Shouldn't this test fail with the filter removed? I would have expected the chart here now...
Contributor
Author
There was a problem hiding this comment.
versionCounts is emptyMap in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490.