This repository was archived by the owner on Aug 20, 2025. It is now read-only.
reflect-lint: Support Kotlin annotations with default retention#189
Open
PhilGlass wants to merge 3 commits intoJakeWharton:masterfrom
Open
reflect-lint: Support Kotlin annotations with default retention#189PhilGlass wants to merge 3 commits intoJakeWharton:masterfrom
PhilGlass wants to merge 3 commits intoJakeWharton:masterfrom
Conversation
Contributor
|
Based on the kdoc you linked to me it looks like you still must put |
Author
|
@TWiStErRob You're right, that's the wrong documentation link. It was late! I found another issue with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default retention for annotations written in Kotlin is RUNTIME, but
dagger-reflect-lintcurrently flags any Kotlin annotation without an explicit@Retention(AnnotationRetention.RUNTIME)as an error.