This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Fix looking up generics when injecting fields in generic subclasses.#167
Closed
amatkovsky wants to merge 2 commits intoJakeWharton:masterfrom
Closed
Fix looking up generics when injecting fields in generic subclasses.#167amatkovsky wants to merge 2 commits intoJakeWharton:masterfrom
amatkovsky wants to merge 2 commits intoJakeWharton:masterfrom
Conversation
Contributor
|
Is this a duplicate of this? #129 |
Contributor
Author
I am not sure. It looks like your pr deals with generics when resolving jit bindings while this pr is about resolving bindings for the fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds a test to cover the case when there are @Inject annotated fields with type parameters. Real world example: a class
BaseFragment<P extends Presenter>with a fieldP presenter.The fix included is just an ad-hoc solution to highlight the issue and help come up with proper fix.