Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Renovate configuration to centralize and simplify the management of trusted organizations. By removing manager-specific scoping, the configuration now provides a more consistent and maintainable approach to auto-merging dependencies across different ecosystems. Additionally, it improves automation efficiency by enabling auto-merge for lock file maintenance tasks. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The rules were scattered, wide and deep, With manager locks we had to keep. Now unified and clean they stand, With auto-merge across the land. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Updates the org-wide Renovate preset to make “trusted org” auto-merge behavior independent of the Renovate manager that detected the dependency, and tweaks automerge behavior for maintenance PRs.
Changes:
- Expands the trusted-org packageRule to apply across managers (adds URL-prefixed patterns; removes github-actions-only scoping).
- Enables automerge for
lockFileMaintenancePRs. - Removes now-redundant per-ecosystem trusted rules (e.g., Nix flake inputs, HuggingFace custom.regex) and narrows Terraform provider trust to
bpg/*.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6cf60df to
0eadde4
Compare
… automerge Trust is org-based, not manager-based. A package from github/** should auto-merge whether detected by github-actions, custom.regex, or nix manager. Changes: - Remove matchManagers constraint from trusted orgs rule - Remove matchUpdateTypes constraint — trusted orgs get ALL update types (major, minor, patch, digest, pin, etc.) - Merge GitHub Actions + Nix flake input trust lists into single rule - Include both bare (github/**) and URL-prefixed (https://github.com/github/**) patterns since different managers report depName differently - Add automerge to lockFileMaintenance config - Remove redundant Nix flake inputs rule (orgs now in unified rule) - Remove redundant HuggingFace custom.regex rule (covered by source URL rule) - Remove hashicorp/* from Terraform providers rule (now in unified rule) - Expand trusted orgs: ansible, aws-ia, bitwarden, codecov, criblio, DopplerHQ, huggingface, kubernetes, kubernetes-sigs, nix-darwin, nix-systems, obra, open-telemetry, ossf, pre-commit, pypa, renovatebot, semgrep, sigstore Fixes: nix-ai#381 (github/gh-aw not auto-merging via custom.regex manager) (claude)
0eadde4 to
dfab0c3
Compare
PR Summary
Overview
Unifies Renovate's trusted organization rules into a single manager-agnostic
configuration that applies trust across all update managers and update types.
Consolidates separate GitHub Actions and Nix flake input trust lists while
expanding coverage to 47 trusted organizations. Adds lock file maintenance
auto-merge.
Changes
(GitHub Actions, Nix flakes, pip, etc.)
types (major, minor, patch, pin)
unified rule
lockFileMaintenanceupdates nowauto-merge for all managers
custom.regex rule (superseded by unified rule)
kubernetes, kubernetes-sigs, nix-darwin, nix-systems, obra, open-telemetry,
ossf, pre-commit, pypa, renovatebot, semgrep, sigstore
Test Plan
(not just GitHub Actions)