Skip to content

Add CohpAndDosComponent#1

Merged
JaGeo merged 12 commits intoJaGeo:mainfrom
naik-aakash:add_lobster_integration
May 9, 2025
Merged

Add CohpAndDosComponent#1
JaGeo merged 12 commits intoJaGeo:mainfrom
naik-aakash:add_lobster_integration

Conversation

@naik-aakash
Copy link
Copy Markdown
Collaborator

@naik-aakash naik-aakash commented May 8, 2025

Hi @JaGeo ,

I have now added the CohpAndDosComponent to this branch. Currently, one can switch between bonding analysis type interactively and corresponding plot, text descriptions and environments identified are updated automatically.

Features added

  • Get relevant bonds interactive cohp plots alongside dos from Lobstery by means of LobsterPy and existing dos plotter in crystaltoolkit
  • Include Bonding analysis summary and calculation quality texts
  • Include visualization of LobsterEnv identified environments
  • Hovering over atoms shows Mulliken charges and edges show the ICOHP values in the visualizer

Todos

@naik-aakash
Copy link
Copy Markdown
Collaborator Author

Attaching a screenshot of the rendered app for reference

App_overview

Looking forward to hear your thoughts on it

@JaGeo
Copy link
Copy Markdown
Owner

JaGeo commented May 8, 2025

@naik-aakash That's amazing! I think we might have to think together with MP team what to do when there are many local environments (maybe, we only show the most important ones first etc.)

The whole structure, including the environments, was too messy, I guess? We could have it as an additional option if you think it is worth the effort.

Comment on lines +432 to +433
neighbour_weights = [
i["edge_properties"]["ICOHP"] for i in local_env_data
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure you can simply assign this to each bond by order. If you remember, there might have been a bug here. This is something to recheck.

@naik-aakash
Copy link
Copy Markdown
Collaborator Author

naik-aakash commented May 9, 2025

@naik-aakash That's amazing! I think we might have to think together with MP team what to do when there are many local environments (maybe, we only show the most important ones first etc.)

The whole structure, including the environments, was too messy, I guess? We could have it as an additional option if you think it is worth the effort.

Hi @JaGeo, thanks. That's a good point. Currently, all the environments identified will always be stacked in two columns, one below the other. Similar to ChemEnv on MP website. So it should not look messy, I imagine. But yeah, something to discuss.
(I will try out for some more complex structures and see how it looks overall)

Also, I could not find the best place to put the whole structure in the current layout. I had looked at very small, simple examples, so I cannot comment on whether it will look messy.

@JaGeo
Copy link
Copy Markdown
Owner

JaGeo commented May 9, 2025

We should discuss together with the MP team if we could offer the Lobster-based environment analysis in the main depiction of the crystal structure on the MP website:
image

Maybe, for now, we just provide an example that one can visualize this as well.

@JaGeo JaGeo merged commit 78d9370 into JaGeo:main May 9, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants