Implement AI scientist mechanism for chromaworks#4
Open
nico97118 wants to merge 1 commit intoItWorkedInCAD:mainfrom
Open
Implement AI scientist mechanism for chromaworks#4nico97118 wants to merge 1 commit intoItWorkedInCAD:mainfrom
nico97118 wants to merge 1 commit intoItWorkedInCAD:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was contributing to ALH, I was also working on a fork of ChromaWorks.
I’ve long wanted to make this mod’s parts fully usable.
ChromaWorks provides a set of chips to create your own remote probe with custom capabilities.
One of these capabilities is a “data analyzer,” which is essentially a small, uncrewed lab.
The problem is that the stock ModuleScienceConverter requires scientists onboard to generate science.
I created a new ScienceConverter module, CW_ModuleScienceConverter, inheriting from the stock module.
This module overrides the GetScientists() method to detect “CW AI Scientists” chips attached to the same parent (the probe core). This mechanism allows users to make the lab more efficient by adding “virtual” scientists.
Since I really appreciate your mod, I prepared this patch (originally for my personal use) to make ALH compatible with this new virtual ScienceConverter.
I leave it to you to decide whether to integrate it into your repository. At the moment, I am the only one using my ChromaWorks fork, but having ALH compatible with it shouldn’t hurt anyone.
Cheers,
Nok