Implement EC checks for science Transfers#3
Open
nico97118 wants to merge 1 commit intoItWorkedInCAD:mainfrom
Open
Implement EC checks for science Transfers#3nico97118 wants to merge 1 commit intoItWorkedInCAD:mainfrom
nico97118 wants to merge 1 commit intoItWorkedInCAD:mainfrom
Conversation
Save and use EC per MIT for science transfers - Store the calculated ecPerMit value in the ALH module on loaded vessels. - Retrieve ecPerMit during science transfer (loaded and unloaded) to accurately estimate required ElectricCharge. - Ensures consistent energy checks across loaded and unloaded vessels for efficient science transmission. - Consume EC on loaded vessels when transmissions occurs - Check unloaded vessels has enough EC for transmissions (cannot consume EC on unloaded)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Save and use EC per MIT for science transfers
Logs of different use-cases
Before loading vessel, ecpermit fallback to -1 (disabled).
After loading vessel, ecPerMit is estimated and saved. (LOADED)
After unloading vessel, ecPerMit is retrieved and used for EC check.
Unsufficient EC for transfer, transfer skipped (LOADED).
Unsufficient EC for transfer, transfer skipped (UNLOADED).