[UP] ⬆️ Update S3Operator chart to support new s3Operator ver…#77
Open
Donatien26 wants to merge 1 commit intomasterfrom
Open
[UP] ⬆️ Update S3Operator chart to support new s3Operator ver…#77Donatien26 wants to merge 1 commit intomasterfrom
Donatien26 wants to merge 1 commit intomasterfrom
Conversation
Donatien26
force-pushed
the
update-s3operator-chart
branch
3 times, most recently
from
335809d to
0f097ff
Compare
sathieu
suggested changes
Oct 18, 2024
Contributor
sathieu
left a comment
sathieu
left a comment
There was a problem hiding this comment.
A few non-blocking comments ...
|
|
||
| s3user: | ||
| overrideExistingSecret: false No newline at end of file | ||
| s3: |
Contributor
There was a problem hiding this comment.
Suggested change
| s3: | |
| s3instance: |
| region: us-east-1 | ||
| # secretRef: "my-s3-operator-auth-secret" | ||
| # caCertSecretRef: "my-s3-operator-cert-secret" | ||
| # allowedNamespaces: "" |
Contributor
There was a problem hiding this comment.
Suggested change
| # allowedNamespaces: "" | |
| # allowedNamespaces: [] |
| {{- include "s3-operator.labels" . | nindent 4 }} | ||
| name: default-s3instance-credentials | ||
| type: Opaque | ||
| data: |
Contributor
There was a problem hiding this comment.
Suggested change
| data: | |
| stringData: |
| url: "https://localhost:9000" | ||
| accessKey: "accessKey" | ||
| secretKey: "secretKey" | ||
| caCertificatesBase64: base64encodedPEMFormatCACertificate |
Donatien26
force-pushed
the
update-s3operator-chart
branch
from
0f097ff to
cfa4e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sion