feat: add high-level DispatchFunc() interface for multi-type and mixed dispatch#29
Draft
Ziminli wants to merge 3 commits intofeat/dev-infrafrom
Draft
feat: add high-level DispatchFunc() interface for multi-type and mixed dispatch#29Ziminli wants to merge 3 commits intofeat/dev-infrafrom
DispatchFunc() interface for multi-type and mixed dispatch#29Ziminli wants to merge 3 commits intofeat/dev-infrafrom
Conversation
…and use `DispatchFunc()` to dispatch `DataType` and block sizes with a single call. - add a convenient interface for any `int64_t`-convertible types, which is mostly used for multi-type dispatch and mixed dispatch - use `DispatchFunc()` to dispatch `DataType` and block sizes with a single function call in various kernels' implementation - remove the `CUDA_BLOCK_SIZE_XXX` macros and simply use numbers instead
02e90d5 to
4f7b2a4
Compare
Author
|
NVIDIA MetaX Iluvatar Moore Cambricon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Add a high-level
DispatchFunc()interface for multi-type and mixed dispatch, and useDispatchFunc()to dispatchDataTypeand block size at the same time in various implementations.Key Changes
High-Level Dispatcher Interface:
DispatchFunc()interface for multi-type and mixed dispatch;int64_t-convertible types can use this interface to simplify the dispatch usage.Simplify Block Size Dispatching
DispatchFunc()to dispatchDataTypeand block size at the same time.Remove Unnecessary Macros
CUDA_BLOCK_SIZE_XXXmacros/aliases and simply use numbers instead.Style Correction
Known Issues & Future Work:
TODO