Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Ignite UI CLI template specs to better validate Web Components template metadata/collisions, and modernizes/fixes several igc-ts grid templates (dependencies and usage patterns).
Changes:
- Add a new
webcomponents-specsuite and extend template collision checks forigc-ts. - Initialize
Appin multiple template spec suites and improve assertion contexts. - Update Web Components
igc-tsgrid templates (default/editing/summaries) to use the newer grid APIs and adjust required npm packages.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| spec/templates/webcomponents-spec.ts | New spec coverage for Web Components templates (IDs + igc-ts collision checks). |
| spec/templates/react-spec.ts | Adds App.initialize() and improves collision assertion context. |
| spec/templates/jquery-spec.ts | Adds App.initialize() and improves assertion context for missing IDs. |
| spec/templates/angular-spec.ts | Adds App.initialize() and improves collision assertion context. |
| packages/cli/templates/webcomponents/igc-ts/grid/grid-summaries/index.ts | Adds grids package dependency for the summaries template. |
| packages/cli/templates/webcomponents/igc-ts/grid/grid-summaries/files/src/app/path/filePrefix.ts | Updates summaries sample to register/use IgcGridComponent + .data binding and switches theme css. |
| packages/cli/templates/webcomponents/igc-ts/grid/grid-editing/index.ts | Adds grids package dependency for the editing template. |
| packages/cli/templates/webcomponents/igc-ts/grid/grid-editing/files/src/app/path/filePrefix.ts | Reworks editing sample to igc-grid + transactions-based batch editing UI. |
| packages/cli/templates/webcomponents/igc-ts/grid/default/index.ts | Simplifies template package dependencies to just grids. |
| packages/cli/templates/webcomponents/igc-ts/grid/default/files/src/app/path/filePrefix.ts | Reworks default sample from data grid to igc-grid, adds grouping/filtering wiring and material theme import. |
| packages/cli/templates/webcomponents/igc-ts/grid/default/files/src/app/path/filePrefix.test.ts | Renames describe block to reflect IgcGridComponent. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ges/cli/templates/webcomponents/igc-ts/grid/default/files/src/app/__path__/__filePrefix__.ts
Show resolved
Hide resolved
...ges/cli/templates/webcomponents/igc-ts/grid/default/files/src/app/__path__/__filePrefix__.ts
Show resolved
Hide resolved
...li/templates/webcomponents/igc-ts/grid/grid-editing/files/src/app/__path__/__filePrefix__.ts
Outdated
Show resolved
Hide resolved
...li/templates/webcomponents/igc-ts/grid/grid-editing/files/src/app/__path__/__filePrefix__.ts
Show resolved
Hide resolved
...li/templates/webcomponents/igc-ts/grid/grid-editing/files/src/app/__path__/__filePrefix__.ts
Outdated
Show resolved
Hide resolved
b8205c6 to
7b0d992
Compare
Hristo313
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Grid templates in Web Components and add igc-ts templates checks