Skip to content

Web Components Grids fixes#1562

Merged
damyanpetev merged 2 commits intomasterfrom
dpetev/webcomponents-grids-fixes
Mar 25, 2026
Merged

Web Components Grids fixes#1562
damyanpetev merged 2 commits intomasterfrom
dpetev/webcomponents-grids-fixes

Conversation

@damyanpetev
Copy link
Member

Fix Grid templates in Web Components and add igc-ts templates checks

@coveralls
Copy link

coveralls commented Mar 24, 2026

Coverage Status

coverage: 84.816% (+9.7%) from 75.112%
when pulling 7b0d992 on dpetev/webcomponents-grids-fixes
into f2e86d5 on master.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Ignite UI CLI template specs to better validate Web Components template metadata/collisions, and modernizes/fixes several igc-ts grid templates (dependencies and usage patterns).

Changes:

  • Add a new webcomponents-spec suite and extend template collision checks for igc-ts.
  • Initialize App in multiple template spec suites and improve assertion contexts.
  • Update Web Components igc-ts grid templates (default/editing/summaries) to use the newer grid APIs and adjust required npm packages.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
spec/templates/webcomponents-spec.ts New spec coverage for Web Components templates (IDs + igc-ts collision checks).
spec/templates/react-spec.ts Adds App.initialize() and improves collision assertion context.
spec/templates/jquery-spec.ts Adds App.initialize() and improves assertion context for missing IDs.
spec/templates/angular-spec.ts Adds App.initialize() and improves collision assertion context.
packages/cli/templates/webcomponents/igc-ts/grid/grid-summaries/index.ts Adds grids package dependency for the summaries template.
packages/cli/templates/webcomponents/igc-ts/grid/grid-summaries/files/src/app/path/filePrefix.ts Updates summaries sample to register/use IgcGridComponent + .data binding and switches theme css.
packages/cli/templates/webcomponents/igc-ts/grid/grid-editing/index.ts Adds grids package dependency for the editing template.
packages/cli/templates/webcomponents/igc-ts/grid/grid-editing/files/src/app/path/filePrefix.ts Reworks editing sample to igc-grid + transactions-based batch editing UI.
packages/cli/templates/webcomponents/igc-ts/grid/default/index.ts Simplifies template package dependencies to just grids.
packages/cli/templates/webcomponents/igc-ts/grid/default/files/src/app/path/filePrefix.ts Reworks default sample from data grid to igc-grid, adds grouping/filtering wiring and material theme import.
packages/cli/templates/webcomponents/igc-ts/grid/default/files/src/app/path/filePrefix.test.ts Renames describe block to reflect IgcGridComponent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@damyanpetev damyanpetev force-pushed the dpetev/webcomponents-grids-fixes branch from b8205c6 to 7b0d992 Compare March 24, 2026 17:16
@damyanpetev damyanpetev merged commit 2bd3393 into master Mar 25, 2026
3 checks passed
@damyanpetev damyanpetev deleted the dpetev/webcomponents-grids-fixes branch March 25, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants