Fix graph Laplacian docstring and semantic weight scaling in KernelLanguageEntropy#441
Open
Kangwei-g wants to merge 1 commit intoIINemo:mainfrom
Open
Fix graph Laplacian docstring and semantic weight scaling in KernelLanguageEntropy#441Kangwei-g wants to merge 1 commit intoIINemo:mainfrom
Kangwei-g wants to merge 1 commit intoIINemo:mainfrom
Conversation
Correct the definition of the Laplacian matrix and adjust matrix calculations for entailment and contradiction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team!
I was reviewing the implementation of Kernel Language Entropy (KLE) and noticed a couple of details regarding the semantic graph construction that deviate slightly from the formulas in the original paper. I've made the following corrections:
L = W - Dto the standard definitionL = D - W./ 2to strictly align with the paper's formula.matrix_entailandmatrix_contraare now the full sum (with a maximum possible value of 2 instead of 1), I updated thematrix_neutralcalculation to use2 * np.ones(...)to maintain the correct semantic proportions.Let me know if you have any questions!