Fix: support multimodal model configs for attention-based estimators#435
Merged
ArtemVazh merged 2 commits intoIINemo:mainfrom Mar 23, 2026
Merged
Conversation
…sed estimators Multimodal models like Gemma-3 nest text model parameters under `text_config` instead of the top-level config. This causes `AttributeError: 'Gemma3Config' object has no attribute 'num_attention_heads'` when running attention-based uncertainty estimators. Use `getattr(config, "text_config", config)` fallback to resolve `num_attention_heads` and `num_hidden_layers` from the correct config level for both standard and multimodal models.
Collaborator
|
@vndee Hi! Thank you for your interest in our project! These fixes are definitely valuable, but could you also address the lint and Black issues? |
a3b7087 to
679aacd
Compare
Contributor
Author
|
Hey @ArtemVazh, I have just updated it. |
ArtemVazh
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
num_attention_heads,num_hidden_layers) undertext_configinstead of the top-level config object.AttributeError: 'Gemma3Config' object has no attribute 'num_attention_heads'when running attention-based uncertainty estimators.getattr(config, "text_config", config)fallback to resolve these attributes from the correct config level, supporting both standard and multimodal models.Files changed
stat_calculators/greedy_probs.pystat_calculators/sample.pystat_calculators/attention_forward_pass_visual.pyestimators/attention_score.pyestimators/rauq.pyReproduction
Test plan