lookAt MAY be orbit target, lookAt > RotateTransforms for X and Y axes#2436
Merged
lookAt MAY be orbit target, lookAt > RotateTransforms for X and Y axes#2436
Conversation
azaroth42
requested changes
Feb 26, 2026
Member
azaroth42
left a comment
azaroth42
left a comment
There was a problem hiding this comment.
Propose to either delete line 1746 or change to be explicitly that determining the orbit's center point is client implementation specific, per discussion on slack
JulieWinchester
commented
Mar 4, 2026
Contributor
Author
Deleted line 1746. |
mikeapp
approved these changes
Mar 4, 2026
azaroth42
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.