-
Notifications
You must be signed in to change notification settings - Fork 4
feat(perf): skip redundant DDL checks in SQLSampleStore.__init__ #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
michael-johnston
wants to merge
6
commits into
main
Choose a base branch
from
maj_skip_redundant_ddl_checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−2
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
657ba5d
feat(perf): skip redundant DDL checks in SQLSampleStore.__init__
michael-johnston dc824bf
Apply suggestion from @michael-johnston
michael-johnston 43442c7
chore(black): formatting
michael-johnston 630ed2f
Merge remote-tracking branch 'origin/main' into maj_skip_redundant_dd…
michael-johnston 5f2eac7
Merge branch 'main' into maj_skip_redundant_ddl_checks
michael-johnston b8328dd
Merge branch 'main' into maj_skip_redundant_ddl_checks
michael-johnston File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the same as what we added for the resources table (which is why I was asking to update from main, because at first glance I thought the code was the same).
At this point it's worth having a parametrized statement in
orchestrator/metastore/sql/statements.pyfor this