Refactor JUnit 5 tests consolidate BaseTestRSA#1194
Open
Mohit-Rajbhar100698 wants to merge 1 commit intoIBM:mainfrom
Open
Refactor JUnit 5 tests consolidate BaseTestRSA#1194Mohit-Rajbhar100698 wants to merge 1 commit intoIBM:mainfrom
Mohit-Rajbhar100698 wants to merge 1 commit intoIBM:mainfrom
Conversation
Member
|
We did talk about this update some and found the runtimes for the test buckets increased by ~4x. Some additional work here to only run 2048 base keys for multi-thread is being tried. |
Mohit-Rajbhar100698
force-pushed
the
mohit-rajbhar/junit5-BaseTestRSA-consolidation
branch
2 times, most recently
from
22b8ad7 to
87c6137
Compare
Collaborator
Author
|
Since a @MethodSource cannot be overridden using inheritance, we cannot simply extend TestRSA and change the method source to run only the 2048 key size. I created two separate test classes. One class runs all RSA key sizes except 2048, and the other class runs only the 2048 key size for multithread testing. Both classes extend the same base test class (TestRSA), which contains all the common setup and tests. |
jasonkatonica
requested changes
Feb 26, 2026
Mohit-Rajbhar100698
force-pushed
the
mohit-rajbhar/junit5-BaseTestRSA-consolidation
branch
2 times, most recently
from
63b847a to
582ec67
Compare
Mohit-Rajbhar100698
force-pushed
the
mohit-rajbhar/junit5-BaseTestRSA-consolidation
branch
from
582ec67 to
c96af63
Compare
jasonkatonica
requested changes
Mar 4, 2026
Mohit-Rajbhar100698
force-pushed
the
mohit-rajbhar/junit5-BaseTestRSA-consolidation
branch
from
c96af63 to
64f8449
Compare
This change consolidates various tests associated with the former BaseTestRSA into a single parameterized test. Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
mohit-rajbhar/junit5-BaseTestRSA-consolidation
branch
from
64f8449 to
acb856b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change consolidates various tests associated with the former BaseTestRSA into a single parameterized test.
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com