Change GDP deflator for EUR and add factor for EUR_2024#60
Change GDP deflator for EUR and add factor for EUR_2024#60khaeru merged 4 commits intoIAMconsortium:mainfrom
Conversation
danielhuppmann
left a comment
There was a problem hiding this comment.
Thanks, but I'm confused why GDP deflator provided by the World Bank is not correct and has to be modified in this way. Why does the USD deflator not have to be modified in this manner?
Please also add the script that you used to query the data from the World Bank, modify the values, and write the relevant lines. This will help to add more values easily (e.g., 2025 EUR.
|
@danielhuppmann The World Bank provides different indicators. There is the NY.GDP.DEFL.ZS.AD indicator, which provides the GDP deflator as a linked series. This is only available on the country level though. For the Euro area, the World Bank does provide data, but the indicator is NY.GDP.DEFL.KD.ZG, which is an annual %, therefore the calculation is needed. I mentioned this to @khaeru, as having an indicator that is available for the entire Euro area seemed more accurate than just using the deflator for Germany, and we discussed to update the definitions accordingly. Due to time constraints, I didn't download the data using a script, but manually by using the Download option on the World Bank website and did the calculation in Excel. Happy to attach the spreadsheet here if that helps. GDP_deflator_calc_EUR.xlsx |
|
EDIT: Ah, I was too slow. To frame another way:
This to me seemed like sound logic, so I encouraged to open the PR. There many more nuances we could get into. For example, if USD_#### is used to express quantities describing a specific non-USA country (say: Ghana), then in some sense that country's own domestic deflators should be used to change to a different base year, and not the ones of the country (USA) whose currency happens to be picked as units of measurement. But to support choice or detection of this would be a big expansion of scope for the package. |
|
@mwerning the test workflow had been disabled by GitHub for inactivity. I've reenabled it. If you push a new commit or force-push a small change to the existing one, it should run again. |
You should for instance add yourself to AUTHORS. |
|
@khaeru Thank you for the more detailed explanation. I have added today's date to the definitions.txt as the date for the last update for the EUR values and modified the AUTHORS. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 5 5
Lines 201 201
=======================================
Hits 193 193
Misses 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add 2024 to the list of described supported periods for EUR currency conversion. - Bump copyright year.
|
Thanks @mwerning for this helpful contribution! 🥳 |
This PR: