Skip to content

fix: when users clicks public -> private -> public checkbox in the channel creation, it ends up creating the channel on 3rd check switch #37

Merged
Stone-Red-Code merged 2 commits intodevfrom
dev_fix_create_dialog_checkbox
Feb 25, 2026
Merged

fix: when users clicks public -> private -> public checkbox in the channel creation, it ends up creating the channel on 3rd check switch #37
Stone-Red-Code merged 2 commits intodevfrom
dev_fix_create_dialog_checkbox

Conversation

@Stone-Red-Code
Copy link
Copy Markdown
Collaborator

Summary

Fixes:

- [x] when users clicks public -> private -> public checkbox in the channel creation, it ends up creating the channel on 3rd check switch

This was a bug in Terminal.Gui, which was recently fixed by introducing the CommandsToBubbleUp property to control which commands bubble up a view, if a control doesn't handle it. (In this case the CheckBox doesn't handle Command.Accept)

gui-cs/Terminal.Gui#4620

@Stone-Red-Code Stone-Red-Code self-assigned this Feb 25, 2026
@Stone-Red-Code Stone-Red-Code changed the title Dev fix create dialog checkbox fix: when users clicks public -> private -> public checkbox in the channel creation, it ends up creating the channel on 3rd check switch Feb 25, 2026
@Stone-Red-Code Stone-Red-Code removed the request for review from HueByte February 25, 2026 21:28
@Stone-Red-Code Stone-Red-Code force-pushed the dev_fix_create_dialog_checkbox branch from 0820819 to 38d63d8 Compare February 25, 2026 21:29
@Stone-Red-Code Stone-Red-Code merged commit eb4aac9 into dev Feb 25, 2026
3 checks passed
@Stone-Red-Code Stone-Red-Code deleted the dev_fix_create_dialog_checkbox branch February 25, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant