Implement window.queueMicrotask()#1097
Merged
rbri merged 1 commit intoHtmlUnit:masterfrom Mar 12, 2026
Merged
Conversation
rbri
reviewed
Mar 12, 2026
| * @throws Exception if the test fails | ||
| */ | ||
| @Test | ||
| @Alerts({"TypeError", "TypeError", |
Member
There was a problem hiding this comment.
can you please split this test into different ones for the different cases
- called without params
- called with a unsupported param
- simple green path
- ....
Member
There was a problem hiding this comment.
over the time having simpler tests makes debugging on regressions simpler/faster
Contributor
Author
There was a problem hiding this comment.
I have fixed the tests could you take a look
duonglaiquang
force-pushed
the
duong_microTask
branch
from
bade6d2 to
a0eeb2d
Compare
|
Member
|
Thanks... as always |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following
Add queueMicrotask() support for
WindowandWindowOrWorkerGlobalScopeMixin