Add methods to grow node and edge tables#126
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@LynxJinyangii I noticed that a couple of lines are not hit by tests, but otherwise you/LLM seemed to have hit most of the lines https://app.codecov.io/gh/HighlanderLab/RcppTskit/pull/126?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=HighlanderLab |
RcppTskit/NEWS.md
Outdated
| - `TableCollection$node_table_add_row()` now maps `population = NULL` and | ||
| `individual = NULL` to `-1` (`TSK_NULL`) for R-level convenience. | ||
| - `rtsk_edge_table_add_row()` and `TableCollection$edge_table_add_row()` now | ||
| validate `left`/`right` more explicitly (non-`NA`, finite, and `left < right`) | ||
| and require scalar `parent`/`child` IDs. |
There was a problem hiding this comment.
I would drop this in the NEWS.md - this belongs into the function documentation
gregorgorjanc
changed the title
|
Hi @LynxJinyangii, would you mind updating the tests so they cover those |
|
Fixed as suggested, thanks. |
|
ARG... I missed the squashing again. Next time! |
4 participants
No description provided.