Skip to content

Add loading screen#82

Closed
azeier wants to merge 3 commits intoHearthSim:masterfrom
azeier:loadingscreen
Closed

Add loading screen#82
azeier wants to merge 3 commits intoHearthSim:masterfrom
azeier:loadingscreen

Conversation

@azeier
Copy link
Copy Markdown
Contributor

@azeier azeier commented Apr 13, 2016

Based on #81.

  • "Waiting for X..." messages are now logged, rather than displayed.
  • I added a few random loading messages that came to mind. They are randomly picked from.
  • There is probably a better way to do the html/css.
  • Currently doesn't scale with app size - probably doesn't matter.
  • Not amazing, but probably good enough for now. (at least better than "waiting for gamestate..." :))
    • Adding hero images might be nice - would require some preloading prioritization though.

https://cloud.githubusercontent.com/assets/7737910/14500565/eb5a9cbe-01a2-11e6-91e1-4fbd2c6bf5eb.gif

other way around:
loadingscreen2

@beheh
Copy link
Copy Markdown
Collaborator

beheh commented Apr 13, 2016

I really like the second version, nice and smooth transitions as well. Feedback from others? I can look into the scaling. We should also outsource the loading screen into a new component.

@jleclanche
Copy link
Copy Markdown
Member

I prefer the clockwise one as well.

@azeier
Copy link
Copy Markdown
Contributor Author

azeier commented Apr 13, 2016

  • Updated to spin clockwise.
  • Moved loading screen to it's own component

@beheh
Copy link
Copy Markdown
Collaborator

beheh commented Jul 20, 2016

Replaced by #118, some of the code will be reused.

@beheh beheh closed this Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants