fix: align benchmark runtimes with project target frameworks#157
Merged
LeeCampbell merged 4 commits intoHdrHistogram:mainfrom Mar 20, 2026
Merged
Conversation
Replace obsolete benchmark job configuration (Net481, Core 2.1–7.0) with the actual target frameworks: net8.0, net9.0, and net10.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BenchmarkDotNet 0.15.8 does not recognise the net10.0 moniker via CreateForNewVersion, throwing NotImplementedException. Remove the manual job/column config and use DefaultConfig instead. Specific runtimes can be targeted via CLI args (--runtimes net8.0 net9.0). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restore the original percentile/statistics columns and multi-runtime job configuration. Keep net8.0 and net9.0 runtimes (net10.0 is not yet supported by BenchmarkDotNet 0.15.8). Update build.cmd to pass --runtimes net8.0 net9.0 so both configured runtimes are exercised. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
BenchmarkDotNet 0.15.8 supports net10.0 via CoreRuntime.Core10_0, not CreateForNewVersion. Revert build.cmd to original form without --runtimes flag as the jobs are configured in code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
Benchmark Results — Updated Runtime ConfigEnvironment: BenchmarkDotNet v0.15.8, Windows 11, Intel Core i5-14400 2.50GHz, 16 logical / 10 physical cores LeadingZeroCount 64-BitFull results (click to expand)
LeadingZeroCount 32-BitFull results (click to expand)
Recording 32-Bit
All three existing benchmark suites ran successfully across .NET 8.0, 9.0, and 10.0 with the updated runtime configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net9.0andnet10.0jobs to match the csproj'sTargetFrameworks(net8.0;net9.0;net10.0)Test plan
dotnet build HdrHistogram.Benchmarking/succeeds with 0 errorsdotnet format HdrHistogram.Benchmarking/ --verify-no-changespasses🤖 Generated with Claude Code