This repository was archived by the owner on Feb 20, 2026. It is now read-only.
Fix Client UI crash when removing agent in Table View#581
Open
OBITORASU wants to merge 1 commit intoHavocFramework:mainfrom
Open
Fix Client UI crash when removing agent in Table View#581OBITORASU wants to merge 1 commit intoHavocFramework:mainfrom
OBITORASU wants to merge 1 commit intoHavocFramework:mainfrom
Conversation
There is a bug which causes the client to crash if the user tries to remove an agent from the table view.
Author
|
Fixes and Resolves #581. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug that causes the client to crash if the user tries to remove an agent from the table view. This is due to a use-after-erase where
MainNode->Node->removeChild( NodeList[ i ]->Node )is being called afterNodeList.erase( NodeList.begin() + i ). This can lead to accessing the wrong element or undefined behavior via an out-of-bounds access.The change proposed moves the
removeChildcall before theeraseto ensure operations onNodeList[i]are done while the index is valid.