Add ability to check if an attribute exists#39
Merged
leonhandreke merged 1 commit intoHaDiNet:masterfrom Jan 10, 2018
Merged
Conversation
Since hasattr isn't sufficient to check if attributes really exist and aren't just empty sets for convenience of modifying entries add functionality to entries to check if a given attribute exists.
leonhandreke
approved these changes
Jan 10, 2018
Member
leonhandreke
left a comment
leonhandreke
left a comment
There was a problem hiding this comment.
Thanks for working on this, looks great :). I hope this fully solves the problem you were having with the API.
Ship it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since hasattr isn't sufficient to check if attributes really exist
and aren't just empty sets for convenience of modifying entries
add functionality to entries to check if a given attribute exists.
Based on what @leonhandreke suggested in #38 - hope this is close to what you visioned. Sorry for the long delay.