fix: replace bare except clauses with specific exception types#80
Open
haosenwang1018 wants to merge 1 commit intoHKUDS:mainfrom
Open
fix: replace bare except clauses with specific exception types#80haosenwang1018 wants to merge 1 commit intoHKUDS:mainfrom
haosenwang1018 wants to merge 1 commit intoHKUDS:mainfrom
Conversation
Bare 'except:' catches BaseException including SystemExit and KeyboardInterrupt, which can mask critical errors and make debugging harder. Replace with appropriate specific exception types: - browser_env.py: except Exception (Playwright timeout/navigation) - local_env.py: except (subprocess.SubprocessError, OSError) - registry.py: except (TypeError, OSError) for inspect.getfile()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several files use bare
except:which catchesBaseExceptionincludingSystemExitandKeyboardInterrupt. This can mask critical errors and make debugging harder (PEP 8 E722).Changes
browser_env.py(2 sites)Exceptionlocal_env.py(subprocess.SubprocessError, OSError)registry.py(TypeError, OSError)inspect.getfile()on builtins/C extensionsWhy specific types matter
Bare
except:silently swallowsKeyboardInterrupt(Ctrl+C) andSystemExit, preventing clean shutdown. Using specific exception types preserves the intended error-swallowing behavior while allowing critical signals to propagate.