style: use 'is None' instead of '== None' per PEP 8#79
Open
haosenwang1018 wants to merge 1 commit intoHKUDS:mainfrom
Open
style: use 'is None' instead of '== None' per PEP 8#79haosenwang1018 wants to merge 1 commit intoHKUDS:mainfrom
haosenwang1018 wants to merge 1 commit intoHKUDS:mainfrom
Conversation
PEP 8 recommends using 'is None' / 'is not None' for singleton comparisons since None is a singleton object. Using '==' can give unexpected results if __eq__ is overridden. Files changed: - autoagent/tools/meta/edit_workflow.py - constant.py - evaluation/math500/run_infer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
== Nonewithis Noneacross 3 files, following PEP 8 guidance:Changes
autoagent/tools/meta/edit_workflow.py== Noneis Noneconstant.py== Noneis Noneevaluation/math500/run_infer.py== Noneis NoneWhy
Using
==for None checks can produce incorrect results if an object overrides__eq__.is Noneis both safer and idiomatic Python.