[Issue #649] Adding Plugins to Common Grants#668
Conversation
|
🚀 Website Preview Deployed! Preview your changes at: https://cg-pr-668.billy-daly.workers.dev This preview will be automatically deleted when the PR is closed. |
bryan-thompsoncodes
left a comment
There was a problem hiding this comment.
LGTM, played around with local website plugin views look sharp and the filtering works well even if there isn't much to filter yet 😄
| @@ -0,0 +1,50 @@ | |||
| { | |||
| "ts-cg-grants-gov": { | |||
| "label": "TypeScript Common-Grants Plugin", | |||
There was a problem hiding this comment.
Can we change this to match the name of the actual plugin? Or add a section that has that name?
So @common-grants/cg-grants-gov for the TypeScript plugin?
There was a problem hiding this comment.
Sorry my comment meant to suggest that we make the label match the package name, or add a new attribute for package name, rather than changing the slug.
The reason we don't want to make the slug match the package name is that there might be name collisions between Python and TypeScript plugins, especially for third party TypeScript plugins that won't be prefixed with @common-grants/ since that's reserved for packages published to our npm org.
widal001
left a comment
There was a problem hiding this comment.
Woohoo!! This is a really exciting addition 🚀
|
🗑️ Preview Cleaned Up The preview for this PR has been automatically deleted. |

Summary
Changes proposed
This PR adds a plugin catalog page to the CommonGrants website and introduces bidirectional cross-linking between plugins and the custom fields they implement.
/pluginsindex page listing all plugins fromcontent/plugins/index.json, with filtering by language and system/plugins/[slug]page rendered viaPluginDetails.astro, showing plugin metadata and the custom fields it exposes asCustomFieldCardcomponentslinking to each field's detail page
CustomFieldDetails.astro—Added a "Used By Plugins" section that filtersplugins/index.jsonfor plugins containing thecurrent field and renders each as a
PluginCatalogCardPluginDetails.astro— Added aCustomFieldCardgrid (mirrors the pattern above)Context for reviewers
The cross-linking works as follows:
/custom-fields/agency), a "Used By Plugins" section appears only when at least one plugin includes that field. Each card links to/plugins/[slug]./plugins/ts-cg-grants-gov), the custom fields section rendersCustomFieldCardcomponents, each linking to/custom-fields/[id].Additional information
Verification:
/custom-fields/agency— confirm a "Used By Plugins" section appears with cards for bothts-cg-grants-govandpy-cg-grants-gov/plugins/[slug]detail page/custom-fields/[id]/custom-fields/eligibilityCriteria(not used by either plugin) — confirm no "Used By Plugins" section appears/plugins— confirm the plugin catalog index renders correctly