Skip to content

Fix TemporaryCollectionItem reference bug #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hoikas merged 2 commits into from
Feb 26, 2025
Merged

Fix TemporaryCollectionItem reference bug #437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23af121
Fix TemporaryCollectionItem reference bug
Jrius Feb 24, 2025
c6f2c4d
Fix import
Jrius Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions korman/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from contextlib import contextmanager
import math
from typing import *
from uuid import uuid4

@contextmanager
def bmesh_from_object(bl):
Expand Down Expand Up @@ -62,12 +63,14 @@ def __exit__(self, type, value, traceback):
@contextmanager
def TemporaryCollectionItem(collection):
item = collection.add()
# Blender may recreate the `item` instance as the collection grows and shrink...
# Assign it a unique name so we know which item to delete later on.
name = item.name = str(uuid4())
try:
yield item
finally:
index = next((i for i, j in enumerate(collection) if j == item), None)
if index is not None:
collection.remove(index)
index = collection.find(name)
collection.remove(index)

class TemporaryObject:
def __init__(self, obj, remove_func):
Expand Down