Open
Conversation
# Conflicts: # jukebox/adapters/inbound/config.py # jukebox/di_container.py # tests/jukebox/adapters/inbound/test_config.py # tests/jukebox/test_jukebox_di_container.py
…om/msgerbush/jukebox into feature/phase2-settings-write # Conflicts: # tests/jukebox/settings/test_resolve.py
…gs-write # Conflicts: # discstore/adapters/inbound/api_controller.py # discstore/adapters/inbound/config.py # discstore/app.py # discstore/di_container.py # jukebox/app.py # jukebox/settings/__init__.py # jukebox/settings/file_settings_repository.py # jukebox/settings/resolve.py # jukebox/settings/service_protocols.py # tests/discstore/adapters/inbound/test_api_controller.py # tests/discstore/adapters/inbound/test_config.py # tests/discstore/test_discstore_app.py # tests/jukebox/settings/test_resolve.py
msgerbush
force-pushed
the
feature/phase6-sonos-runtime
branch
from
742dae0 to
69937b6
Compare
msgerbush
force-pushed
the
feature/phase6-sonos-runtime
branch
from
93d99bc to
244cd05
Compare
msgerbush
force-pushed
the
feature/phase6-sonos-runtime
branch
from
244cd05 to
5552808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #156. Depends on #165.
Summary
selected_groupsettings into a concrete runtime coordinator/member target before playback startupNotes
This focuses on actually building and targeting the desired Sonos speaker groups from the settings. Once this is connected to the UI, it will allow us to create and update speaker groups (#128 and #129). A lot of extra work went into making it fault-tolerant since querying and editing the Sonos topology requires a lot of network requests.
This is the last feature that we need to support in the settings, after this the remaining work for #126 is to do a pass on the CLI UX (#158) and to wire up a new Settings UI (#157).