Fix Clippy lints

[evading]

Clippy lints suggesting parenthesizing expressions are fixed.

Thank you!

Thank you for your contribution.
Please make sure that your submission includes the following:

Must

• The code compiles without errors or warnings.
• All tests pass and in the best case you also added new tests.
• cargo +stable fmt was run.
• cargo +stable clippy yields no warnings.
• Your changes were added to the CHANGELOG.md in the proper section.
• You add a description of your work to this PR.
• You added proper docs (in code, rustdoc and README.md) for your
  newly added features and code.

[epontan]

Nice, thank you! LGTM 👍

[Ironedde]

Hey @evading!

Always nice to fix additional lints 👍
I'm assuming this is a fix for clippy::precedence_bits[1]?

Since these lints are currently not part of this regular checks, is there some specific linting group, or subset, that you would propose us adding to the GitHub actions?

[1] https://rust-lang.github.io/rust-clippy/master/index.html#precedence_bits

[evading]

clippy::precedence_bits

It's actually clippy:precedence and I find it weird that the check doesn't get it. I'm not that well versed on GitHub actions but there is some error reported in the clippy action.

I just ran cargo +stable clippy in the repo, using Cargo 1.84.0 and it reported all these lints.

[Ironedde]

Interesting. When I run it locally with the same toolchain: cargo +1.84.0 clippy I don't get any warnings.
And I don't get any warnings on 1.86.0 either.

Do you have some global config that enables a larger subset of lints?
And was it only this singular lint that showed up for you?

Furthermore, clippy::precedence_bits was added as part of rust toolchain 1.86.0 (set as allow) so that would explain why you don't see it.

Regarding why the GitHub action isn't working. We have seen the issue before.
It is actually reporting the clippy check correctly (pass or fail), but (for some reason) when running a check against a fork with the same name as the main repo mcan it runs into issues displaying the errors.

[evading]

Weird thing is that now after running rustup update I can't reproduce the lint either. Not even with cargo +1.84.0 clippy. Even though 1.84.0 was the version I was running before.

[Ironedde]

Interesting. I thought that the clippy version was tied to the rust toolchain version. But from what you see, it seams like clippy has been updated independently from rust.

At least I know why the lint doesn't show up on 1.86.0, some functionality from precedence was moved into the new precedence_bits[1]. Which was set to allow.

But I guess this means that there is no need for a clippy fix anymore?

[1] rust-lang/rust-clippy#14115

[evading]

It's weird indeed. I actually checked the clippy version and that seems to be tied to the toolchain. I still can't reproduce though. I'll close this.