Skip to content

Merge Extras and Parameters into one#911

Merged
GregHib merged 13 commits intomainfrom
parameterization
Mar 8, 2026
Merged

Merge Extras and Parameters into one#911
GregHib merged 13 commits intomainfrom
parameterization

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Mar 8, 2026

  • Fix unconverted fishing and picking configs
  • Delete GearDefinitions
  • Delete CategoryDefinitions
  • Delete ParameterDefinition
  • Replace Extra with Parameterized Map<Int, Any>

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2026

Qodana for JVM

1 new problem were found

Inspection name Severity Problems
Unused import directive 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

❌ Patch coverage is 5.57769% with 948 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.23%. Comparing base (d87c624) to head (0ecfcbe).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...tlin/world/gregs/voidps/cache/definition/Params.kt 0.00% 673 Missing ⚠️
...in/world/gregs/voidps/cache/definition/Category.kt 0.00% 38 Missing ⚠️
...s/voidps/engine/data/definition/ItemDefinitions.kt 14.28% 28 Missing and 2 partials ⚠️
...ngine/entity/character/player/skill/level/Level.kt 0.00% 18 Missing ⚠️
...rld/gregs/voidps/cache/definition/Parameterized.kt 15.00% 16 Missing and 1 partial ⚠️
.../src/main/kotlin/content/skill/ranged/ammo/Ammo.kt 35.71% 5 Missing and 4 partials ⚠️
...gs/voidps/cache/definition/data/CanoeDefinition.kt 0.00% 7 Missing ⚠️
...dps/engine/data/definition/InterfaceDefinitions.kt 0.00% 7 Missing ⚠️
...gregs/voidps/engine/data/config/SpellDefinition.kt 0.00% 6 Missing ⚠️
...dps/engine/data/definition/AnimationDefinitions.kt 25.00% 5 Missing and 1 partial ⚠️
... and 57 more
Additional details and impacted files
Files with missing lines Coverage Δ
...gregs/voidps/cache/config/data/StructDefinition.kt 100.00% <100.00%> (ø)
...gregs/voidps/cache/config/decoder/StructDecoder.kt 50.00% <100.00%> (-16.67%) ⬇️
...ps/cache/definition/data/ClientScriptDefinition.kt 32.30% <100.00%> (ø)
.../kotlin/world/gregs/voidps/engine/EngineModules.kt 0.00% <ø> (ø)
...gs/voidps/engine/data/definition/AreaDefinition.kt 100.00% <100.00%> (ø)
...tlin/content/entity/player/command/ItemCommands.kt 50.76% <100.00%> (ø)
...tlin/content/entity/player/command/MetaCommands.kt 12.63% <ø> (ø)
...otlin/content/entity/player/equip/WornEquipment.kt 40.74% <100.00%> (+3.70%) ⬆️
...ain/kotlin/content/skill/crafting/SilverCasting.kt 23.18% <ø> (+0.65%) ⬆️
...ame/src/main/kotlin/content/skill/ranged/Ranged.kt 35.84% <100.00%> (ø)
... and 67 more

... and 7 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #911      +/-   ##
============================================
- Coverage     38.61%   38.23%   -0.39%     
+ Complexity     7679     7678       -1     
============================================
  Files          1560     1555       -5     
  Lines         61939    62523     +584     
  Branches      15691    15674      -17     
============================================
- Hits          23917    23904      -13     
- Misses        32714    33306     +592     
- Partials       5308     5313       +5     
Components Coverage Δ
Content 36.27% <30.00%> (-0.01%) ⬇️
Engine 45.95% <16.33%> (+0.56%) ⬆️
Network 60.85% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 3066dc4 into main Mar 8, 2026
5 checks passed
@GregHib GregHib deleted the parameterization branch March 8, 2026 18:10
@GregHib GregHib mentioned this pull request Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant