Skip to content

Playoff Schedule#3

Open
yoavs8 wants to merge 22 commits intomasterfrom
playoff-schedule/init
Open

Playoff Schedule#3
yoavs8 wants to merge 22 commits intomasterfrom
playoff-schedule/init

Conversation

@yoavs8
Copy link
Contributor

@yoavs8 yoavs8 commented Dec 7, 2025

the project makes a schedule for playoff and events that happened and will happen

@YoniKiriaty YoniKiriaty changed the title close to end added alot of things including css and html waiting for cr Playoff Schedule Dec 9, 2025
Copy link
Contributor

@YoniKiriaty YoniKiriaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought this was good then I saw the App.tsx

@YoniKiriaty YoniKiriaty added the project-init A PR to start off a project label Dec 10, 2025
Copy link
Contributor

@YoniKiriaty YoniKiriaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good✅

@GreenBlitz GreenBlitz deleted a comment from YoniKiriaty Jan 8, 2026
throw new Error(`HTTP error, status: ${response.status}`);
}

return response.json() as Promise<T>;

Check warning

Code scanning / ESLint

Disallow type assertions that narrow a type Warning

Unsafe assertion from any detected: consider using type guards or a safer assertion.

export type MatchesSimpleType = typeof matchSimple._A;

export const urlMatches = (eventKey: string) => `/events/${eventKey}/matches`;

Check warning

Code scanning / ESLint

Require explicit return and argument types on exported functions' and classes' public class methods Warning

Missing return type on function.
@@ -0,0 +1,4 @@
// בס"ד

export const urlRankings = (eventKey: string) =>

Check warning

Code scanning / ESLint

Require explicit return and argument types on exported functions' and classes' public class methods Warning

Missing return type on function.
const fullUrl = joinUrl(targetPath);
const response = await fetch(fullUrl);
if (response.ok) {
return (await response.json()) as T;

Check warning

Code scanning / ESLint

Disallow type assertions that narrow a type Warning

Unsafe assertion from any detected: consider using type guards or a safer assertion.
@@ -0,0 +1,2 @@
// בס"ד
export const urlRankings = (eventKey: string) => `/events/${eventKey}/rankings`;

Check warning

Code scanning / ESLint

Require explicit return and argument types on exported functions' and classes' public class methods Warning

Missing return type on function.
app.use(express.urlencoded({ limit: "10mb", extended: true }));

app.use(
cors({

Check warning

Code scanning / ESLint

Disallow calling a value with type `any` Warning

Unsafe call of a type that could not be resolved.

const queryClient = new QueryClient();

createRoot(document.getElementById("root")!).render(

Check warning

Code scanning / ESLint

Disallow non-null assertions using the `!` postfix operator Warning

Forbidden non-null assertion.
return null;
}
return {
opponentAlliance: opponentData.alliance,

Check warning

Code scanning / ESLint

Disallow assigning a value with type `any` to variables and properties Warning

Unsafe assignment of an error typed value.
return {
opponentAlliance: opponentData.alliance,
opponentTeams: opponentData.teams,
ourAlliance: ourAllianceEntry.alliance,

Check warning

Code scanning / ESLint

Disallow assigning a value with type `any` to variables and properties Warning

Unsafe assignment of an error typed value.
): OpponentInfo | null => {
const potentialNextOpponents = nextMatchAlliances
.map(({ alliance, teams }) => ({
alliance,

Check warning

Code scanning / ESLint

Disallow assigning a value with type `any` to variables and properties Warning

Unsafe assignment of an error typed value.
if (potentialNextOpponents.length === potentialOpponentsFirst) {
const [opponent] = potentialNextOpponents;
return {
opponentAlliance: opponent.alliance,

Check warning

Code scanning / ESLint

Disallow assigning a value with type `any` to variables and properties Warning

Unsafe assignment of an error typed value.
return [];
}

if (feedingMatch.winning_alliance) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invert

};
}

if (target === "finals") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

split the insides of this if into a getNextFinal or smthing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge master and use the one in maaster

RJ0907 added a commit that referenced this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project-init A PR to start off a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants