Skip to content

fix(#3625): Accordion Refinements#3766

Open
willcodeforcoffee wants to merge 1 commit intodevfrom
eric/3625-accordion-refinements
Open

fix(#3625): Accordion Refinements#3766
willcodeforcoffee wants to merge 1 commit intodevfrom
eric/3625-accordion-refinements

Conversation

@willcodeforcoffee
Copy link
Copy Markdown
Collaborator

@willcodeforcoffee willcodeforcoffee commented Apr 6, 2026

Before (the change)

Accordion is all unrefined and gross. 🤢

image

After (the change)

Fixed all discrepancies from issue #3625.

  • Large heading Accordion is 64px tall
  • Small heading Accordion is 48px tall
  • After size adjustments above:
    • the small heading text is vertically centered for
      • primary text
      • secondary text
    • large heading secondary text is vertically centered
  • Ensure other slotted elements are still vertically centered after update
  • Add motion tokens to animate the following:
    • "hover" - Background transform from white to grey use --goa-motion-duration-short-2
    • "open" - Show accordion content area use --goa-motion-curve-expressive and --goa-motionDuration-short-3
    • "close" - Hide accordion content area, use --goa-motion-curve-expressive-exit and --goa-motionDuration-short-3
image

😭🎺😭 Notes and sad trombones 😭🎺😭

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

Make sure you check out the eric/3625-accordion-refinements branch from design-tokens and update package.json devDependencies to use it:

"@abgov/design-tokens": "file://../design-tokens",
"@abgov/design-tokens-v2": "npm:@abgov/design-tokens@2.2.1",

Run npm i after making the change.

This PR will close Issue #3625

@willcodeforcoffee willcodeforcoffee self-assigned this Apr 6, 2026
@willcodeforcoffee willcodeforcoffee added Accordion 2.0 P3 Priority 3 (nice to have): Valuable, but safe to release after launch. labels Apr 6, 2026
@willcodeforcoffee willcodeforcoffee force-pushed the eric/3625-accordion-refinements branch from 25f7b18 to acd6c01 Compare April 6, 2026 21:47
background-color: var(--goa-accordion-color-bg-heading-hover);
border: var(--goa-accordion-border-hover, var(--goa-accordion-border));
color: var(--goa-accordion-color-heading-hover);
transition: var(--goa-motion-duration-medium-1) background-color
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use --goa-motionDuration-short-2 to align more closely with the "short-2" we are using for other similar elements.

@willcodeforcoffee willcodeforcoffee force-pushed the eric/3625-accordion-refinements branch from 7415d38 to 6134646 Compare April 9, 2026 02:43
@willcodeforcoffee willcodeforcoffee linked an issue Apr 9, 2026 that may be closed by this pull request
@willcodeforcoffee willcodeforcoffee force-pushed the eric/3625-accordion-refinements branch from 6134646 to aab8bdc Compare April 9, 2026 03:08
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 9, 2026

Deploy Preview for benji-docs-previews ready!

Name Link
🔨 Latest commit 6053134
🔍 Latest deploy log https://app.netlify.com/projects/benji-docs-previews/deploys/69d978d2fb0dcc0008d6bfa8
😎 Deploy Preview https://deploy-preview-3766--benji-docs-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@willcodeforcoffee willcodeforcoffee force-pushed the eric/3625-accordion-refinements branch from f38eaeb to 6348b73 Compare April 9, 2026 21:31
@willcodeforcoffee willcodeforcoffee force-pushed the eric/3625-accordion-refinements branch from 5c66489 to 6053134 Compare April 10, 2026 22:25
@willcodeforcoffee willcodeforcoffee marked this pull request as ready for review April 10, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.0 Accordion P3 Priority 3 (nice to have): Valuable, but safe to release after launch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accordion refinement

2 participants