Open
Conversation
25f7b18 to
acd6c01
Compare
Spark450
reviewed
Apr 8, 2026
| background-color: var(--goa-accordion-color-bg-heading-hover); | ||
| border: var(--goa-accordion-border-hover, var(--goa-accordion-border)); | ||
| color: var(--goa-accordion-color-heading-hover); | ||
| transition: var(--goa-motion-duration-medium-1) background-color |
Collaborator
There was a problem hiding this comment.
Lets use --goa-motionDuration-short-2 to align more closely with the "short-2" we are using for other similar elements.
7415d38 to
6134646
Compare
6134646 to
aab8bdc
Compare
✅ Deploy Preview for benji-docs-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
f38eaeb to
6348b73
Compare
5c66489 to
6053134
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
Accordion is all unrefined and gross. 🤢
After (the change)
Fixed all discrepancies from issue #3625.
--goa-motion-duration-short-2--goa-motion-curve-expressiveand--goa-motionDuration-short-3--goa-motion-curve-expressive-exitand--goa-motionDuration-short-3😭🎺😭 Notes and sad trombones 😭🎺😭
Make sure that you've checked the boxes below before you submit the PR
Steps needed to test
Make sure you check out the
eric/3625-accordion-refinementsbranch from design-tokens and updatepackage.jsondevDependenciesto use it:Run
npm iafter making the change.This PR will close Issue #3625