fix(#3640): adjust alignment for work side menu badge (both component and text)#3758
Open
fix(#3640): adjust alignment for work side menu badge (both component and text)#3758
Conversation
mxsoco
force-pushed
the
mxsoco/3640-work-side-menu-badge
branch
2 times, most recently
from
f101f00 to
705f203
Compare
chrisolsen
approved these changes
Apr 7, 2026
mxsoco
force-pushed
the
mxsoco/3640-work-side-menu-badge
branch
2 times, most recently
from
35d12ba to
582bee2
Compare
bdfranck
reviewed
Apr 9, 2026
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
Let's adjust the badge with a margin to preserve alignment for multi-line labels.
libs/web-components/src/components/work-side-menu/WorkSideMenuItem.svelte
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for benji-docs-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mxsoco
force-pushed
the
mxsoco/3640-work-side-menu-badge
branch
from
79754b3 to
b1130e8
Compare
bdfranck
approved these changes
Apr 10, 2026
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I looked at the latest changes...
- ✅ I see a badge is aligned when the label is one line
- ✅ I see a badge is top aligned when the label is multiple lines
Looks good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before (the change)
After (the change)
Added a
1pxmargin to the top of goa-badge to center text more. Additionally, adjusted.menu-itemitems to be center aligned.Steps needed to test