Skip to content

Add unit tests for ospatch_apt_upgrade.go#938

Open
ganochenkodg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
ganochenkodg:ospatch-aptupgrade-unittests
Open

Add unit tests for ospatch_apt_upgrade.go#938
ganochenkodg wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
ganochenkodg:ospatch-aptupgrade-unittests

Conversation

@ganochenkodg
Copy link
Copy Markdown

With this PR better test coverage for ./ospatch/apt_upgrade.go was reached:

github.com/GoogleCloudPlatform/osconfig/ospatch/apt_upgrade.go:36: AptGetUpgradeType 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/apt_upgrade.go:43: AptGetExcludes 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/apt_upgrade.go:50: AptGetExclusivePackages 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/apt_upgrade.go:57: AptGetDryRun 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/ospatch/apt_upgrade.go:64: RunAptGetUpgrade 0.0% -> 100.0%

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ganochenkodg
Once this PR has been reviewed and has the lgtm label, please assign paulinakania for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested a review from savija-tv March 27, 2026 23:00
@google-oss-prow google-oss-prow bot requested a review from zoltak-g March 27, 2026 23:00
@google-oss-prow
Copy link
Copy Markdown

Hi @ganochenkodg. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant