Skip to content

Add/improve unit tests for agentendpoint/patch_task.go#936

Open
ganochenkodg wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
ganochenkodg:agentendpoint-patchtask-unittests
Open

Add/improve unit tests for agentendpoint/patch_task.go#936
ganochenkodg wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
ganochenkodg:agentendpoint-patchtask-unittests

Conversation

@ganochenkodg
Copy link
Copy Markdown

With this PR better test coverage for ./agentendpoint/patch_task.go was reached:

github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:30: systemRebootRequired 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:64: complete 50.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:87: setStep 75.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:95: handleErrorState 66.7% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:102: reportFailed 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:117: reportCompletedState 75.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:130: reportContinuingState 53.8% -> 84.6%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:159: prePatchReboot 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:163: postPatchReboot 0.0% -> 100.0%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:167: rebootIfNeeded 0.0% -> 45.7%
github.com/GoogleCloudPlatform/osconfig/agentendpoint/patch_task.go:228: run 38.5% -> 69.2%

Average test coverage for this file 53.68% -> 93.72%

@ganochenkodg ganochenkodg marked this pull request as draft March 26, 2026 03:33
@google-oss-prow google-oss-prow bot requested review from burov and savija-tv March 26, 2026 03:34
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ganochenkodg
Once this PR has been reviewed and has the lgtm label, please assign ekremenetskii for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @ganochenkodg. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

defer os.RemoveAll(td)
oldStateFile := taskStateFile
taskStateFile = filepath.Join(td, "testState")
defer func() { taskStateFile = oldStateFile }()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are duplicated code statements for preserving task state or to create a temp directory or setting a test client. Can you move them to functions and reuse across tests

@ganochenkodg ganochenkodg marked this pull request as ready for review March 27, 2026 01:45
@google-oss-prow google-oss-prow bot requested a review from ekremenetskii March 27, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants