Skip to content

Cover agentconfig functionality by unit tests#925

Open
iliatsuprik wants to merge 5 commits intoGoogleCloudPlatform:masterfrom
iliatsuprik:agentconfig-unittests
Open

Cover agentconfig functionality by unit tests#925
iliatsuprik wants to merge 5 commits intoGoogleCloudPlatform:masterfrom
iliatsuprik:agentconfig-unittests

Conversation

@iliatsuprik
Copy link
Copy Markdown
Contributor

This PR contains unit tests and minor changes in code for github.com/GoogleCloudPlatform/osconfig/agentconfig package.
Initial coverage: 58.1%, current coverage: 96.4%

Changes in the code of main app:

  • move 5 seconds retry interval and runtime.GOOS into global variable. That's needed for mocking it in tests

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 12, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow google-oss-prow bot requested a review from burov March 12, 2026 18:49
@google-oss-prow google-oss-prow bot requested a review from savija-tv March 12, 2026 18:49
@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: iliatsuprik
Once this PR has been reviewed and has the lgtm label, please assign paulinakania for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @iliatsuprik. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@burov
Copy link
Copy Markdown
Member

burov commented Mar 13, 2026

/gcbrun

2 similar comments
@burov
Copy link
Copy Markdown
Member

burov commented Mar 13, 2026

/gcbrun

@burov
Copy link
Copy Markdown
Member

burov commented Mar 13, 2026

/gcbrun

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from 9b2e8c2 to c555736 Compare March 16, 2026 11:40
@burov
Copy link
Copy Markdown
Member

burov commented Mar 16, 2026

/gcbrun

Copy link
Copy Markdown
Member

@burov burov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might benefit from using table driven testing more often in this CL, as well i see a lot of code duplication in test set-up, some of the code repetitions are low hanging fruits and can be just extracted to separate function as is.

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch 2 times, most recently from dd95306 to 3310076 Compare March 17, 2026 19:01
@iliatsuprik
Copy link
Copy Markdown
Contributor Author

@burov, thanks for the comprehensive review. I refactored most of the tests according to your comments. Could you check them again?

@burov
Copy link
Copy Markdown
Member

burov commented Mar 18, 2026

/gcbrun

@iliatsuprik iliatsuprik force-pushed the agentconfig-unittests branch from 3310076 to 6abe8ad Compare March 25, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants