partial success on event-exporter writing logs#475
partial success on event-exporter writing logs#475snowhork wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
26f5a3f to
4fadf2f
Compare
|
@osalau @sophieliu15 please review. |
| Entries: entries, | ||
| LogName: logName, | ||
| Resource: resource, | ||
| PartialSuccess: true, |
There was a problem hiding this comment.
Thanks for sending in the PR!
We also need to count how many entries are successfully delivered in our metrics here and their corresponding latency: https://github.com/GoogleCloudPlatform/k8s-stackdriver/blob/master/event-exporter/sinks/stackdriver/writer.go#L66-L67
If there is an easy way to count those, could you update corresponding metrics? If not, feel free to send us a feature request PR and we will prioritize the work based on our team capacity and priority.
We should enable partial success on writing log entries.
In the for loop, some entries are in bad format, and it receives StatusBadRequest. But, if partials success is not enabled, some appropriate entries may lose.