Skip to content

Enable WinRM also on Windows Client Professional#2286

Open
dgouju wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
dgouju:patch-1
Open

Enable WinRM also on Windows Client Professional#2286
dgouju wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
dgouju:patch-1

Conversation

@dgouju
Copy link
Copy Markdown

@dgouju dgouju commented Mar 13, 2024

My customer is building a Windows 11 Professional image, by adapting the .wf.json file. The shared post_install.ps1 only enables WinRM on Windows Client Enterprise, not Professional. Per https://learn.microsoft.com/en-us/answers/questions/721139/programmatically-(powershell)-getting-windows-vers , in this case $pn ends with Pro.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Mar 13, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgouju
Once this PR has been reviewed and has the lgtm label, please assign a-crate for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link
Copy Markdown

Hi @dgouju. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant